Skip to content

[ETHEREUM-CONTRACTS] update SuperTokenV1Library#2048

Merged
d10r merged 12 commits intodevfrom
lib-update
Jan 14, 2025
Merged

[ETHEREUM-CONTRACTS] update SuperTokenV1Library#2048
d10r merged 12 commits intodevfrom
lib-update

Conversation

@d10r
Copy link
Collaborator

@d10r d10r commented Dec 31, 2024 •
edited
Loading

  • Add createPoolWithCustomERC20Metadata
  • SuperTokenV1Library distribute / distributeFlow return actualAmount / actualFlowRate

@github-actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited by d10r
Loading

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r d10r marked this pull request as ready for review January 2, 2025 19:47
@d10r d10r requested a review from hellwolf as a code owner January 2, 2025 19:47
hellwolf
hellwolf reviewed Jan 7, 2025
View reviewed changes
packages/ethereum-contracts/CHANGELOG.md Outdated

### Changed
- Fixed deployment of SimpleForwarder (solved an issue which caused batch operation `OPERATION_TYPE_SIMPLE_FORWARD_CALL` to always revert)
- `SuperTokenV1Library.distributeFlow`: return `actualFlowRate`
Copy link
Contributor

@hellwolf hellwolf Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be breaking change for some; I think I might have a few places doing assert(whateverreturningbool)

Copy link
Contributor

@hellwolf hellwolf Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that's an okay breaking change, since it's not at ABI level, and code will not compile for the new function signature if they relying on returning bool.

hellwolf
hellwolf approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to update CHANGELOG to mark some of the changes BREAKING

@codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.16667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (1edc4ed) to head (64a71c9).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...m-contracts/contracts/apps/SuperTokenV1Library.sol 79.16% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2048      +/-   ##
==========================================
- Coverage   88.15%   88.08%   -0.07%     
==========================================
  Files         109      109              
  Lines        6862     6900      +38     
  Branches      985      997      +12     
==========================================
+ Hits         6049     6078      +29     
- Misses        811      820       +9     
  Partials        2        2
Flag Coverage Δ
ethereum-contracts 94.02% <79.16%> (-0.20%) ⬇️
sdk-core 88.08% <79.16%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d10r d10r merged commit bd84747 into dev Jan 14, 2025
22 of 24 checks passed
@d10r d10r deleted the lib-update branch January 14, 2025 14:11
@github-actions
Copy link

github-actions bot commented Jan 14, 2025

XKCD Comic Relif

Link: https://xkcd.com/2048
https://xkcd.com/2048

@d10r d10r mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellwolf hellwolf hellwolf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d10r @hellwolf